Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AssetMapper] Exclude _*.scss files #1241

Conversation

Kocal
Copy link
Member

@Kocal Kocal commented Sep 19, 2023

Q A
License MIT
Doc issue/PR symfony/symfony-docs#...

See symfony/ux#1111

cc @weaverryan

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) September 19, 2023 23:34
@github-actions
Copy link

Thanks for the PR 😍

How to test these changes in your application

  1. Define the SYMFONY_ENDPOINT environment variable:

    # On Unix-like (BSD, Linux and macOS)
    export SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes/flex/pull-1241/index.json
    # On Windows
    SET SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes/flex/pull-1241/index.json
  2. Install the package(s) related to this recipe:

    composer req 'symfony/flex:^1.16'
    composer req 'symfony/asset-mapper:^6.3'
  3. Don't forget to unset the SYMFONY_ENDPOINT environment variable when done:

    # On Unix-like (BSD, Linux and macOS)
    unset SYMFONY_ENDPOINT
    # On Windows
    SET SYMFONY_ENDPOINT=

Diff between recipe versions

In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes.
I'm going keep this comment up to date with any updates of the attached patch.

@weaverryan
Copy link
Member

Hmm, on second thought, perhaps we should add this to the SassBundle documentation? It looks weird to me to have sass-specific config by default with AssetMapper.

@fabpot
Copy link
Member

fabpot commented Jan 18, 2024

Closing as explained by @weaverryan

@fabpot fabpot closed this Jan 18, 2024
auto-merge was automatically disabled January 18, 2024 07:12

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants